gh-124771: Add the PYTHON_GC_PRESET env var.#124772
Draft
nascheme wants to merge 2 commits intopython:mainfrom
Draft
gh-124771: Add the PYTHON_GC_PRESET env var.#124772nascheme wants to merge 2 commits intopython:mainfrom
PYTHON_GC_PRESET env var.#124772nascheme wants to merge 2 commits intopython:mainfrom
Conversation
nascheme
added
DO-NOT-MERGE
interpreter-core
vstinner
reviewed
Oct 1, 2024
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
The name PYTHON_GC_PRESET was suggested.
Member
Author
Yeah, that's a better name. I've updated the PR. Still need the |
nascheme
changed the title
PYTHON_GC_STRAGEGY env var.PYTHON_GC_PRESET env var.
Member
|
The PR is a draft. Does it mean that you're not sure if it's a good idea or not? Should it be reviewed or not yet? |
Member
Author
|
The code is not yet complete (need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a WIP. We need to discuss if this is actually a good idea and what the options should be if it is.
There should be a
gc.set_preset()function, which is not yet implemented. Also need unit tests for this functionality. The initconfig logic is fairly complex and I'm not sure I did everything correct.📚 Documentation preview 📚: https://cpython-previews--124772.org.readthedocs.build/